Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aliasing violation in align_to_mut #69581

Merged
merged 1 commit into from Feb 29, 2020
Merged

Conversation

@RalfJung
Copy link
Member

RalfJung commented Feb 29, 2020

Fixes #68549

I decided to add the testcase here to make it all one PR, but if you prefer I can also add that test case in the Miri repo instead.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 29, 2020

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 29, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-29T12:41:22.0278814Z ========================== Starting Command Output ===========================
2020-02-29T12:41:22.0282082Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/6fbfa46a-3d45-4a8f-8b3b-3d73d3461671.sh
2020-02-29T12:41:22.0282626Z 
2020-02-29T12:41:22.0286746Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-29T12:41:22.0307718Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69581/merge to s
2020-02-29T12:41:22.0311402Z Task         : Get sources
2020-02-29T12:41:22.0311778Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-29T12:41:22.0312104Z Version      : 1.0.0
2020-02-29T12:41:22.0312332Z Author       : Microsoft
---
2020-02-29T12:41:23.0183660Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-29T12:41:23.0197899Z ##[command]git config gc.auto 0
2020-02-29T12:41:23.0201899Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-29T12:41:23.0205531Z ##[command]git config --get-all http.proxy
2020-02-29T12:41:23.0212088Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69581/merge:refs/remotes/pull/69581/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@RalfJung RalfJung force-pushed the RalfJung:align_to_mut branch from 0c7e3bd to c34451f Feb 29, 2020
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Feb 29, 2020

r? @Centril @bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 29, 2020

📌 Commit c34451f has been approved by Centril

@nagisa

This comment has been minimized.

Copy link
Contributor

nagisa commented Feb 29, 2020

Thanks for figuring this out @RalfJung

bors added a commit that referenced this pull request Feb 29, 2020
Rollup of 7 pull requests

Successful merges:

 - #69504 (Use assert_ne in hash tests)
 - #69571 (remove unneeded .as_ref() calls.)
 - #69572 (use .iter() instead of .into_iter() on references)
 - #69581 (fix aliasing violation in align_to_mut)
 - #69582 (improve transmute and Vec::from_raw_parts docs)
 - #69584 (Correct comment to match behavior)
 - #69587 (rustc_parse: Tweak the function parameter name check)

Failed merges:

r? @ghost
@bors bors merged commit 02381db into rust-lang:master Feb 29, 2020
4 checks passed
4 checks passed
pr Build #20200229.39 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@RalfJung RalfJung deleted the RalfJung:align_to_mut branch Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.