constify mem::forget #69617
Merged
constify mem::forget #69617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
LukasKalbertodt
suggested changes
Mar 2, 2020
LukasKalbertodt
added
S-waiting-on-author
|
@bors r+ rollup |
|
📌 Commit a30b0a6 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Mar 2, 2020
Rollup of 6 pull requests Successful merges: - #68682 (Add documentation to compiler intrinsics) - #69544 (Unrevert "Remove `checked_add` in `Layout::repeat`") - #69617 (constify mem::forget) - #69622 (Rename `syntax` in librustc_ast/README.md) - #69623 (stash API: remove panic to fix ICE.) - #69624 (Toolstate: Don't block beta week on already broken tools.) Failed merges: - #69626 (Toolstate: don't duplicate nightly tool list.) r? @ghost
|
No test for this? |
Im writing them now! |
Merged
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2020
…lan-DPC const forget tests Adds tests for rust-lang#69617
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 11, 2020
…lan-DPC const forget tests Adds tests for rust-lang#69617
3 tasks
|
Constification PRs should always Cc @rust-lang/wg-const-eval |
|
@RalfJung Sorry, will do in the future! |
XAMPPRocky
pushed a commit
to rust-lang/rust-forge
that referenced
this pull request
Apr 1, 2020
I was made aware of this [here](rust-lang/rust#69617 (comment)). I guess this note is useful in this document.
XAMPPRocky
pushed a commit
to XAMPPRocky/rust-forge
that referenced
this pull request
Apr 4, 2020
…t-lang#326) I was made aware of this [here](rust-lang/rust#69617 (comment)). I guess this note is useful in this document.
|
Next time someone adds a const-intrinsic, please make sure to also remove the (then obsolete) implementation in Miri once it lands. |
|
Oh wait, this does not even use the intrinsic... oops sorry.^^ |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 11, 2020
stabilize const mem::forget Stabilizes const `mem::forget` as implemented in rust-lang#69617 and tracked in rust-lang#69616. Closes rust-lang#69616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #69616