Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak when vec::IntoIter panics during drop #69828

Merged
merged 1 commit into from Mar 11, 2020

Conversation

@RalfJung
Copy link
Member

RalfJung commented Mar 8, 2020

Fixes #69770

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Mar 8, 2020

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytm

This comment has been minimized.

Copy link
Member

kennytm commented Mar 10, 2020

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 10, 2020

📌 Commit 528cbc4 has been approved by kennytm

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Mar 10, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

bors added a commit that referenced this pull request Mar 11, 2020
Rollup of 8 pull requests

Successful merges:

 - #66472 (--show-coverage json)
 - #69603 (tidy: replace `make check` with `./x.py test` in documentation)
 - #69760 (Improve expression & attribute parsing)
 - #69828 (fix memory leak when vec::IntoIter panics during drop)
 - #69850 (panic_bounds_check: use caller_location, like PanicFnLangItem)
 - #69876 (Add long error explanation for E0739)
 - #69888 ([Miri] Use a session variable instead of checking for an env var always)
 - #69893 (librustc_codegen_llvm: Use slices instead of 0-terminated strings)

Failed merges:

r? @ghost
@bors bors merged commit 080d413 into rust-lang:master Mar 11, 2020
4 checks passed
4 checks passed
pr Build #20200308.33 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@RalfJung RalfJung deleted the RalfJung:vec-leak branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.