Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic IP support in HermitCore #70136

Merged
merged 1 commit into from
Apr 4, 2020
Merged

add basic IP support in HermitCore #70136

merged 1 commit into from
Apr 4, 2020

Conversation

stlankes
Copy link
Contributor

  • add initial version to support sockets
  • use TcpStream as test case
  • HermitCore uses smoltcp as IP stack for pure Rust applications
  • further functionalities (e.g. UDP support) will be added step by step
  • in principle, the current PR is a revision of add basic IP support in HermitCore #69404

@stlankes
add basic IP support in HermitCore
57b7203 
- add initial version to support sockets
- use TcpStream as test case
- HermitCore uses smoltcp as IP stack for pure Rust applications
- further functionalities (e.g. UDP support) will be added step by step
@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020
@joelpalmer joelpalmer added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2020
@Dylan-DPC-zz
Copy link

r? @dtolnay

@rust-highfive rust-highfive assigned dtolnay and unassigned shepmaster Mar 30, 2020
dtolnay
dtolnay approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed this beyond confirming that it only affects target_os = "hermit" which appears to be your project based on https://github.com/hermitcore/libhermit-rs/graphs/contributors.

@dtolnay
Copy link
Member

dtolnay commented Apr 4, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2020

📌 Commit 57b7203 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2020
@bors
Copy link
Contributor

bors commented Apr 4, 2020

⌛ Testing commit 57b7203 with merge 1b521f5...

@bors
Copy link
Contributor

bors commented Apr 4, 2020

☀️ Test successful - checks-azure
Approved by: dtolnay
Pushing 1b521f5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2020
@bors bors merged commit 1b521f5 into rust-lang:master Apr 4, 2020
This was referenced Apr 4, 2020
Merged
Merged
@stlankes stlankes deleted the network_tcp branch April 4, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@stlankes @rust-highfive @Dylan-DPC-zz @dtolnay @bors @shepmaster @joelpalmer