Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reword unused variable warning #70300

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Reword unused variable warning #70300

merged 1 commit into from
Mar 23, 2020

Conversation

aleksator
Copy link
Contributor

Fixes #66636

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 23, 2020
@aleksator
Copy link
Contributor Author

Seems like I missed a comma in the wording:
"if this is intentional*,* prefix it with an underscore"

Feedback on wording is welcome (here or in the issue)

@aleksator aleksator force-pushed the 66636_reword_unused_variable_warning branch from 6626184 to b35c302 Compare March 23, 2020 09:23
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@GuillaumeGomez
Copy link
Member

Looks good to me. 👍

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 23, 2020

📌 Commit b35c302 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2020
@Centril Centril mentioned this pull request Mar 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2020
@bors
Auto merge of rust-lang#70330 - Centril:rollup-ts0clvx, r=Centril
1edd389 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#68700 (Add Wake trait for safe construction of Wakers.)
 - rust-lang#69494 (Stabilize --crate-version option in rustdoc)
 - rust-lang#70080 (rustc_mir: remove extra space when pretty-printing MIR.)
 - rust-lang#70195 (Add test for issue rust-lang#53275)
 - rust-lang#70199 (Revised span-to-lines conversion to produce an empty vec on DUMMY_SP.)
 - rust-lang#70299 (add err_machine_stop macro)
 - rust-lang#70300 (Reword unused variable warning)
 - rust-lang#70315 (Rename remaining occurences of Void to Opaque.)
 - rust-lang#70318 (Split long derive lists into two derive attributes.)

Failed merges:

r? @ghost
@bors bors merged commit 1bb0c92 into rust-lang:master Mar 23, 2020
@aleksator aleksator deleted the 66636_reword_unused_variable_warning branch March 26, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message suggesting prefixing with underscore is unhelpful
5 participants
@aleksator @rust-highfive @Dylan-DPC-zz @GuillaumeGomez @bors