Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 24, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

Didn't review the changes beyond making sure that they're just touching imports -- I presume you've just done the normal refactoring here. In any case import changes should be essentially harmless.

@bors
Copy link
Collaborator

bors commented Mar 24, 2020

📌 Commit 9172899 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
…acrum

normalize some imports & prefer direct ones

r? @Mark-Simulacrum
Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
…acrum

normalize some imports & prefer direct ones

r? @Mark-Simulacrum
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70331 (Increase verbosity when using update syntax with private fields)
 - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code)
 - rust-lang#70361 (Update backtrace crate to 0.3.46)
 - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate)
 - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors)
 - rust-lang#70373 (normalize some imports & prefer direct ones)
 - rust-lang#70376 (Add test for rust-lang#66312)

Failed merges:

r? @ghost
@bors bors merged commit d894f5e into rust-lang:master Mar 25, 2020
@Centril Centril deleted the canon-imports branch March 25, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants