Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide task_context when lowering body #70640

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Hide task_context when lowering body #70640

merged 1 commit into from
Apr 3, 2020

Conversation

jonas-schievink
Copy link
Contributor

Fixes #70594

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@jonas-schievink jonas-schievink mentioned this pull request Mar 31, 2020
Closed
@cramertj
Copy link
Member

cramertj commented Apr 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2020

📌 Commit c7d9d89 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 1, 2020
@Centril
Rollup merge of rust-lang#70640 - jonas-schievink:async-ice, r=cramertj
5a0c0b3 
Hide `task_context` when lowering body

Fixes rust-lang#70594
@Centril Centril mentioned this pull request Apr 1, 2020
Closed
@Centril
Copy link
Contributor

Centril commented Apr 1, 2020

Failed in #70648 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2020
@jonas-schievink
Copy link
Contributor Author

This part of the diagnostic is missing:

  ::: $SRC_DIR/libcore/future/mod.rs:LL:COL
   |
LL |     F: Future,
   |        ------ required by this bound in `std::future::poll_with_context`

No clue why though, it passes on the PR builder

@jonas-schievink
Copy link
Contributor Author

Running that Docker container locally, the UI test also passes (though the std::net tests seem to fail, probably due to some misconfiguration). Not sure what else to do here now, does anyone have an idea?

@jonas-schievink jonas-schievink added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2020
@jonas-schievink
Copy link
Contributor Author

Ah it's just #53081. There's a fix for that in the pipeline (#70642) so I can just wait until that lands.

@jonas-schievink
Copy link
Contributor Author

@bors r=cramertj

@bors
Copy link
Contributor

bors commented Apr 3, 2020

📌 Commit c7d9d89 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 3, 2020
@Dylan-DPC
Rollup merge of rust-lang#70640 - jonas-schievink:async-ice, r=cramertj
0b4f8fc 
Hide `task_context` when lowering body

Fixes rust-lang#70594
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 3, 2020
Closed
@Centril Centril mentioned this pull request Apr 3, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2020
@bors
Auto merge of rust-lang#70747 - Centril:rollup-2vx9bve, r=Centril
74bd074 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#69860 (Use associated numeric consts in documentation)
 - rust-lang#70576 (Update the description of the ticket to point at RFC 1721)
 - rust-lang#70597 (Fix double-free and undefined behaviour in libstd::syn::unix::Thread::new)
 - rust-lang#70640 (Hide `task_context` when lowering body)
 - rust-lang#70641 (Remove duplicated code in trait selection)
 - rust-lang#70707 (Remove unused graphviz emitter)
 - rust-lang#70720 (Place TLS initializers with relocations in .tdata)
 - rust-lang#70735 (Clean up E0502 explanation)
 - rust-lang#70741 (Add test for rust-lang#59023)

Failed merges:

r? @ghost
@bors bors merged commit a928f64 into rust-lang:master Apr 3, 2020
@jonas-schievink jonas-schievink deleted the async-ice branch April 3, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal compiler error: no type for local variable
5 participants
@jonas-schievink @rust-highfive @cramertj @bors @Centril