fix Miri assignment sanity check #70806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Apr 5, 2020
Comment on lines
233
to
234
| // 2. Subtyping is used. While all normal lifetimes are erased, higher-ranked lifetime | ||
| // bounds with their late-bound regions are still around and can lead to type differences. |
There was a problem hiding this comment.
"higher-ranked lifetime bounds" -> "higher-ranked types" (fn types and dyn Trait types are "higher-ranked" because they can "forall"-bind lifetimes - this is what the Binder wrapper indicates)
There was a problem hiding this comment.
Done. I also replaced "regions" by "lifetimes".
|
@bors r=eddyb |
|
📌 Commit e52a451 has been approved by |
bors
added
S-waiting-on-bors
eddyb
approved these changes
Apr 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 5, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70558 (Fix some aliasing issues in Vec) - rust-lang#70760 (docs: make the description of Result::map_or more clear) - rust-lang#70769 (Miri: remove an outdated FIXME) - rust-lang#70776 (clarify comment in RawVec::into_box) - rust-lang#70806 (fix Miri assignment sanity check) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @eddyb for pointing me to the right APIs!
r? @eddyb
Fixes #70804