Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing trait method suggests incorrect code (self parameter not named "self"). #71188

Merged
merged 3 commits into from Apr 19, 2020
Merged

Fixed missing trait method suggests incorrect code (self parameter not named "self"). #71188

merged 3 commits into from Apr 19, 2020

Conversation

Duddino
Copy link
Contributor

@Duddino Duddino commented Apr 16, 2020

fixes #71150

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matthewjasper (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2020
@Duddino
Copy link
Contributor Author

Duddino commented Apr 16, 2020

I've just found a bug: if the type is &Box<Self>, the compiler will output &self instead of self: &Box<Self>

@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2020

📌 Commit f36f78f has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#71188 - Duddino:fix, r=matthewjasper
5ab2d64 
Fixed missing trait method suggests incorrect code (self parameter not named "self").

fixes rust-lang#71150
This was referenced Apr 19, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2020
@bors
Auto merge of rust-lang#71326 - Dylan-DPC:rollup-hdlkdj5, r=Dylan-DPC
1b7dec9 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#71107 (Address concerns of weak-into-raw)
 - rust-lang#71188 (Fixed missing trait method suggests incorrect code (self parameter not named "self"). )
 - rust-lang#71300 (Clarify when to use the tracking issue template)
 - rust-lang#71315 (Add example in the alternative in std::mem::transmute docs)
 - rust-lang#71319 (Clean up E0522 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 36791da into rust-lang:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hint about missing trait method suggests incorrect code (self parameter not named "self").
4 participants
@Duddino @rust-highfive @matthewjasper @bors