More str cleanup #7123
Closed
More str cleanup #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huonw |
|
@Kimundi I see. Moving it to |
The first two become map_chars and lev_distance. Also, remove a few allocations in rustdoc.
This moves them all into the traits submodule, and delegates Ord to the TotalOrd instance. It also deletes the stand-alone lt, gt, ge and le functions.
| @@ -22,6 +22,7 @@ use markdown_writer::WriterFactory; | |||
| use pass::Pass; | |||
| use sort_pass; | |||
|
|
|||
| use core::iterator::IteratorUtil; | |||
There was a problem hiding this comment.
IteratorUtil is in prelude now, so this could be removed
bors
added a commit
that referenced
this pull request
Jun 16, 2013
Moves all the remaining functions that could reasonably be methods to be methods, except for some FFI ones (which I believe @erickt is working on, possibly) and `each_split_within`, since I'm not really sure the details of it (I believe @Kimundi wrote the current implementation, so maybe he could convert it to an external iterator method on `StrSlice`, e.g. `word_wrap_iter(&self) -> WordWrapIterator<'self>`, where `WordWrapIterator` impls `Iterator<&'self str>`. It probably won't be too hard, since it's already a state machine.) This also cleans up the comparison impls for the string types, except I'm not sure how the lang items `eq_str` and `eq_str_uniq` need to be handled, so they (`eq_slice` and `eq`) remain stand-alone functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all the remaining functions that could reasonably be methods to be methods, except for some FFI ones (which I believe @erickt is working on, possibly) and
each_split_within, since I'm not really sure the details of it (I believe @Kimundi wrote the current implementation, so maybe he could convert it to an external iterator method onStrSlice, e.g.word_wrap_iter(&self) -> WordWrapIterator<'self>, whereWordWrapIteratorimplsIterator<&'self str>. It probably won't be too hard, since it's already a state machine.)This also cleans up the comparison impls for the string types, except I'm not sure how the lang items
eq_strandeq_str_uniqneed to be handled, so they (eq_sliceandeq) remain stand-alone functions.