Skip to content

[ConstProp] Use a BitSet<Local> instead of IndexVec<Local, bool> #71312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

[ConstProp] Use a BitSet<Local> instead of IndexVec<Local, bool> #71312

merged 1 commit into from
Apr 23, 2020

Conversation

wesleywiser
Copy link
Member

No description provided.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 19, 2020
@wesleywiser
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Apr 19, 2020

⌛ Trying commit fc31f83c77c693f550e8ad26eaa3dacba34ad6f2 with merge 3054153994c0b4aabefabd27f22ef1761dc8bcd1...

@bors
Copy link
Collaborator

bors commented Apr 19, 2020

☀️ Try build successful - checks-azure
Build commit: 3054153994c0b4aabefabd27f22ef1761dc8bcd1 (3054153994c0b4aabefabd27f22ef1761dc8bcd1)

@rust-timer
Copy link
Collaborator

Queued 3054153994c0b4aabefabd27f22ef1761dc8bcd1 with parent e7497a8, future comparison URL.

@wesleywiser
Copy link
Member Author

Some small memory improvements. CPU seems to be a wash. Seems about as I expected.

Mark-Simulacrum
Mark-Simulacrum reviewed Apr 20, 2020
View reviewed changes
@Mark-Simulacrum
Copy link
Member

wall-time shows some potential improvements, but it might well be within the noise margin (which is quite high for wall-time).

I suspect we should merge this though -- it seems like a bitset is going to behave better as we scale up (e.g., with hundreds of locals), at least from a memory usage perspective.

r=me if you feel similarly on the changes (including if you fix my nit along the way)

@wesleywiser
Copy link
Member Author

@bors r=Mark-Simulacrum rollup=never

(perf)

@bors
Copy link
Collaborator

bors commented Apr 20, 2020

📌 Commit c183b4c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 20, 2020
@Dylan-DPC-zz
Copy link

@bors p=1

@bors
Copy link
Collaborator

bors commented Apr 20, 2020

⌛ Testing commit c183b4c with merge dd27760a008fba35ef8091f1d72a3e86a80758f7...

@bors
Copy link
Collaborator

bors commented Apr 20, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 20, 2020
@wesleywiser
Copy link
Member Author

Kind of looks like it timed out on macOS?

@Dylan-DPC-zz
Copy link

looks spurious

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2020
@bors
Copy link
Collaborator

bors commented Apr 22, 2020

⌛ Testing commit c183b4c with merge 37584210e6da6d45c84443526fc114e8bd83f6e0...

@bors
Copy link
Collaborator

bors commented Apr 22, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2020
@wesleywiser
Copy link
Member Author 

Chocolatey timed out waiting for the command to finish. The timeout 
 specified (or the default value) was '2700' seconds. Perhaps try a 
 higher `--execution-timeout`? See `choco -h` for details.
The install of msys2 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\msys2\tools\chocolateyinstall.ps1'.
 See log for details.

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2020
@bors
Copy link
Collaborator

bors commented Apr 23, 2020

⌛ Testing commit c183b4c with merge 8af87b1...

@bors
Copy link
Collaborator

bors commented Apr 23, 2020

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 8af87b1 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2020
@bors bors merged commit 8af87b1 into rust-lang:master Apr 23, 2020
@bors bors mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wesleywiser @rust-highfive @rust-timer @bors @Mark-Simulacrum @Dylan-DPC-zz @estebank