Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More diagnostic items for Clippy usage #71414

Merged
merged 1 commit into from Apr 22, 2020
Merged

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 22, 2020

This adds a couple of more diagnostic items to be used in Clippy.
I chose these particular ones because they were the types which we seem
to check for the most in Clippy. I'm not sure if the cfg_attr(not(test))
is needed, but it was also used for Vec and a few other types.

cc rust-lang/rust-clippy#5393

r? @Manishearth

This adds a couple of more diagnostic items to be used in Clippy.
I chose these particular ones because they were the types which we seem
to check for the most in Clippy. I'm not sure if the
`cfg_attr(not(test))` is needed, but it was also used for `Vec` and a
few other types.
@rust-highfive rust-highfive added the S-waiting-on-review label Apr 22, 2020
@Manishearth
Copy link
Member

@Manishearth Manishearth commented Apr 22, 2020

@bors r+

@bors
Copy link
Contributor

@bors bors commented Apr 22, 2020

📌 Commit 23b9f46 has been approved by Manishearth

@bors bors added S-waiting-on-bors and removed S-waiting-on-review labels Apr 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 22, 2020
Rollup of 6 pull requests

Successful merges:

 - rust-lang#70970 (Detect mistyped associated consts in `Instance::resolve`.)
 - rust-lang#71203 (Correct await span for async-await error reporting)
 - rust-lang#71214 (Add error code for inner doc error)
 - rust-lang#71337 (Moving all rustdoc-ui tests to check-pass)
 - rust-lang#71412 (Clarify unused_doc_comments note on macro invocations)
 - rust-lang#71414 (More diagnostic items for Clippy usage)

Failed merges:

r? @ghost
@bors bors merged commit 01fdc88 into rust-lang:master Apr 22, 2020
14 checks passed
@phansch phansch deleted the more-diagnostic-items branch Apr 22, 2020
phansch added a commit to phansch/rust-clippy that referenced this issue Apr 23, 2020
In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 rust-lang#5393
bors added a commit to rust-lang/rust-clippy that referenced this issue Apr 23, 2020
Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 #5393

---

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this issue Apr 23, 2020
Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 #5393

---

changelog: none
phansch added a commit to phansch/rust-clippy that referenced this issue Apr 26, 2020
In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 rust-lang#5393
bors added a commit to rust-lang/rust-clippy that referenced this issue Apr 26, 2020
Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 #5393

---

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this issue Apr 26, 2020
Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 #5393

---

changelog: none
bors added a commit to rust-lang/rust-clippy that referenced this issue Apr 26, 2020
Use more diagnostic items

In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 #5393

---

changelog: none
ThibsG pushed a commit to ThibsG/rust-clippy that referenced this issue May 2, 2020
In particular for:

* `VecDeque`
* `String`
* `Mutex`
* `HashMap`
* `HashSet`

cc rust-lang/rust#71414 rust-lang#5393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants