Rollup of 7 pull requests #71556
Merged
Rollup of 7 pull requests #71556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Ralf Jung <post@ralfj.de>
… instead of the other way around.
These are semantically the same, but `find_map()` is more concise.
Co-Authored-By: Amanieu d'Antras <amanieu@gmail.com>
proc_macro: Stabilize `Span::resolved_at` and `Span::located_at` Introduced in rust-lang#47149. Part of rust-lang#54725. Motivation: rust-lang#68716 (comment). Identifiers in proc macros may want to inherit span locations for diagnostics from one tokens (e.g. some tokens from the macro input), but resolve those identifiers from some different location (e.g. from the macro's definition site). This becomes especially important when multiple resolution locations become available with stabilization of [`Span::mixed_site`](rust-lang#68716). Why I think this is the right API for setting span's location and hygiene - rust-lang#69041 (comment). r? @dtolnay
Implement BitOr and BitOrAssign for the NonZero integer types This provides overloaded operators for `NonZero$Int | NonZero$Int`, `NonZero$Int | $Int`, and `$Int | NonZero$Int`. It also provides `BitOrAssign` where `self` is `NonZero$Int`, for symmetry. It's a pretty small conceptual addition, but is good becasue but avoids a case where the operation is obviously sound, but you'd otherwise need unsafe to do it. In crates trying to minimize `unsafe` usage, this is unfortunate and makes working with `NonZero` types often not worth it, even if the operations you're doing are clearly sound. I've marked these as stable as I've been told in the past that trait impls are automatically stable. I'm happy to change it to unstable if this wasn't correct information. I'm not entirely confident what version I should have put down, so I followed https://www.whatrustisit.com. Hopefully it's correct for this. Apologies in advance if this has come up before, but I couldn't find it.
stabilize BTreeMap::remove_entry This PR stabilizes `BTreeMap::remove_entry` as implemented in rust-lang#68378. Closes rust-lang#66714
…nieu
Deprecate `{Box,Rc,Arc}::into_raw_non_null`
Per ongoing FCP at rust-lang#47336 (comment)
See also rust-lang#47336 (comment)
…ulacrum Replace filter_map().next() calls with find_map() These are semantically the same, but `find_map()` is more concise.
Fix comment in docstring example for Error::kind Saw it while reading the docs.
Add missing Send and Sync impls for linked list Cursor and CursorMut. Someone pointed out these to me, and i think it's indeed reasonable to add those impl. r? @Amanieu
|
@bors p=7 rollup=never r+ |
|
📌 Commit 82642d7 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
This was referenced Apr 25, 2020
Closed
|
Something in this rollup had positive perf impact, which is cool
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Span::resolved_atandSpan::located_at#69041 (proc_macro: StabilizeSpan::resolved_atandSpan::located_at){Box,Rc,Arc}::into_raw_non_null#71168 (Deprecate{Box,Rc,Arc}::into_raw_non_null)Failed merges:
r? @ghost