Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: allow gating GHA on everything but macOS #73443

Merged
merged 1 commit into from
Jun 21, 2020
Merged

ci: allow gating GHA on everything but macOS #73443

merged 1 commit into from
Jun 21, 2020

Conversation

pietroalbini
Copy link
Member

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called auto-fallible), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum

@pietroalbini
ci: allow gating gha on everything but macOS
8bc3122 
In our GitHub Actions setup macOS is too unreliable to gate on it, but
the other builders work fine. This commit splits the macOS builders into
a separate job (called auto-fallible), allowing us to gate on the auto
job without failing due to macOS spurious failures.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 17, 2020
@pietroalbini
Copy link
Member Author

This will need to be followed up by a change in RCS to actually enable the gate.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 17, 2020

📌 Commit 8bc3122 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
c2ba2e4 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
@Manishearth Manishearth mentioned this pull request Jun 20, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 20, 2020
@RalfJung
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
5ea7ef4 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
@RalfJung RalfJung mentioned this pull request Jun 20, 2020
Closed
@RalfJung
Copy link
Member

Hm, the arm GHA builder failed in https://github.com/rust-lang-ci/rust/runs/790442563. Does that mean I should take this out of the rollup?

@RalfJung
Copy link
Member 

test slice::rotate_tiny_half ... ok
died due to signal 9
error: test failed, to rerun pass '-p alloc --bench collectionsbenches'


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libtest/Cargo.toml" "-p" "alloc" "--"
expected success, got: exit code: 3

@mati865
Copy link
Contributor

mati865 commented Jun 20, 2020

Cc #73535

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 20, 2020
@Manishearth
Rollup merge of rust-lang#73443 - pietroalbini:gha-auto-fallible, r=M…
89434b6 
…ark-Simulacrum

ci: allow gating GHA on everything but macOS

In our GitHub Actions setup macOS is too unreliable to gate on it, but the other builders work fine. This commit splits the macOS builders into a separate job (called `auto-fallible`), allowing us to gate on the auto job without failing due to macOS spurious failures.

cc rust-lang/rust-central-station#848
r? @Mark-Simulacrum
This was referenced Jun 20, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2020
@bors
Auto merge of rust-lang#73563 - Manishearth:rollup-oowgwwm, r=Manishe…
7058471 
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#72456 (Try to suggest dereferences on trait selection failed)
 - rust-lang#72788 (Projection bound validation)
 - rust-lang#72790 (core/time: Add Duration methods for zero)
 - rust-lang#73227 (Allow multiple `asm!` options groups and report an error on duplicate options)
 - rust-lang#73287 (lint: normalize projections using opaque types)
 - rust-lang#73291 (Pre-compute `LocalDefId` <-> `HirId` mappings and remove `NodeId` <-> `HirId` conversion APIs)
 - rust-lang#73378 (Remove use of specialization from librustc_arena)
 - rust-lang#73411 (Update bootstrap to rustc 1.45.0-beta.2 (1dc0f6d 2020-06-15))
 - rust-lang#73443 (ci: allow gating GHA on everything but macOS)

Failed merges:

r? @ghost
@bors bors merged commit 929f032 into rust-lang:master Jun 21, 2020
@pietroalbini pietroalbini deleted the gha-auto-fallible branch June 22, 2020 10:47
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pietroalbini @Mark-Simulacrum @bors @RalfJung @mati865 @cuviper @rust-highfive