libsyntax cleanup episode 1 #7365
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eek! I'm sorry, I didn't see you working on this. I started working on a higher-efficiency interner a while back already, just never cleaned it up. It keeps all the strings in one buffer, so no separate-allocations overhead. http://people.mozilla.org/~graydon/interner.rs (I think we might also consider shifting to a model wherein all strings are "interned" as slices from file buffers, not (re)allocated strings at all, but that's another matter. It's how many other compilers work.) |
|
@graydon handily, it's easy to adapt, given that Interner is now a trait rather than some ad-hoc struct impl. |
bors
added a commit
that referenced
this pull request
Jun 26, 2013
Sets the stage for further cleanup (especially mass-slaughter of `@`)
xFrednet
pushed a commit
to xFrednet/rust
that referenced
this pull request
May 21, 2022
Fix `cmp_owned` on copy types fixes rust-lang#8803 fixes rust-lang#7365 changelog: Don't lint `cmp_owned` on `From::from` for copy types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the stage for further cleanup (especially mass-slaughter of
@)