Skip to content

Conversation

infinity0
Copy link
Contributor

@infinity0 infinity0 commented Jul 26, 2020

This makes it more obvious that the work-around to #74786 is actually correct, and a custom --remap-path-prefix isn't needed.

In fact the previous comment /rustc/$hash/$crate was wrong, it is not $crate but whatever path exists in the rustc source tree, so either src/$crate or vendor/$crate. I've fixed that as well to avoid future confusion.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2020
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jul 27, 2020
@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 27, 2020

📌 Commit 1f25a4b has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2020
@bors
Copy link
Collaborator

bors commented Jul 28, 2020

⌛ Testing commit 1f25a4b with merge 2c28244...

@bors
Copy link
Collaborator

bors commented Jul 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: nikomatsakis
Pushing 2c28244 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2020
@bors bors merged commit 2c28244 into rust-lang:master Jul 28, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants