Cleanup E0749 #75328
Cleanup E0749 #75328
Conversation
GuillaumeGomez
force-pushed
the
cleanup-e0749
branch
from
6e77980
to
4e78760
Compare
JohnTitor
added
the
S-waiting-on-review
|
@GuillaumeGomez Looks good to me but this feels familiar #75291 to the one you changed earlier. Lol when I was r? and I am slower but when without I am faster. Haha Also, I have some questions regarding the fix. |
| impl !MyTrait for u32 { | ||
| type Foo = i32; // error! | ||
| } | ||
| # fn main() {} |
There was a problem hiding this comment.
Do we suggest how to fix this? Is it clear that the user should remove the type and put?
impl !MyTrait for u32 {}There was a problem hiding this comment.
Hm it's verbose for me. "item" here is ambiguous a bit?
There was a problem hiding this comment.
The explanation below isn't enough?
There was a problem hiding this comment.
Just enough but it is not as straightforward.
There was a problem hiding this comment.
Hum... I'm not sure to see what's missing so could please open a PR with your vision? (let's switch position for once! :p)
Set me as reviewer on it so we can move forward quickly! :)
| declare that a trait is **not** implemented (and never will be) and | ||
| hence there is no need to specify the values for trait methods or | ||
| other items. | ||
| An item was added on a negative impl. |
There was a problem hiding this comment.
@JohnTitor I think the "item" here like you said means "type". Should we change it?
| An item was added on a negative impl. | |
| An associated type was added on a negative impl. |
The one below too.
There was a problem hiding this comment.
Well, "item" means "associated items" so I don't think we should change it.
|
merging this @bors r+ rollup |
|
📌 Commit 4e78760 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 8 pull requests Successful merges: - rust-lang#74200 (Std panicking unsafe block in unsafe fn) - rust-lang#75286 (Add additional case for Path starts with) - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope) - rust-lang#75320 (Detect likely `for foo of bar` JS syntax) - rust-lang#75328 (Cleanup E0749) - rust-lang#75344 (Rename "Important traits" to "Notable traits") - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs) - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies) Failed merges: r? @ghost
r? @pickfire