Skip to content

Conversation

workingjubilee
Copy link
Member

@workingjubilee workingjubilee commented Aug 14, 2020

log had recent yanks, so bumping it.
once_cell 1.1 depended on an old version of parking_lot which depended on a (very) old version of smallvec which had recent UB fixes as noted in #75523, so bumping it. The pre-1.0 of smallvec might not have had the UB, but better to be after and certain the fix is in than before it.

And it 🎼 works on my machine~ 🎵

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2020
@workingjubilee
Copy link
Member Author

Actually, sorry, sec.

@workingjubilee workingjubilee changed the title Bump log -> 0.4.11, once_cell -> 1.4.0 cargo update everything!!! Aug 14, 2020
@workingjubilee workingjubilee changed the title cargo update everything!!! Bump log -> 0.4.11, once_cell 1.4.0 Aug 14, 2020
@workingjubilee
Copy link
Member Author

Apologies for being a three-chain morningstar flail.

@workingjubilee
Copy link
Member Author

workingjubilee commented Aug 15, 2020

Hmm, that does not fail to build here... interesting. Oh, possibly because I'm missing a recent commit... and no. Build does not appear to work on MinGW with once_cell 1.4, but does with log 4.11, so if I come back to this I am going to try to fix that and also figure out why it's seemingly only a problem for MinGW and not myself.

@workingjubilee workingjubilee marked this pull request as draft August 15, 2020 00:20
@workingjubilee workingjubilee changed the title Bump log -> 0.4.11, once_cell 1.4.0 Bump once_cell 1.4.0 Aug 15, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 18, 2020

Is there a reason we're pulling in once_cell instead of dog-fooding #![feature(once_cell)]? Pre-existing, but seems like it could be fixed in this PR.

@Mark-Simulacrum
Copy link
Member

We can switch to that as well, it's just somewhat harder (and dependencies are likely to remain pointing at out-of-tree once cell for some time).

I'm going to close this in favor of the more general bump PR though.

@workingjubilee workingjubilee deleted the update-log branch October 4, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants