Rename rustc_lexer::TokenKind::Not to Bang #75743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
added
the
S-waiting-on-review
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r=davidtwco rollup |
|
📌 Commit ec9bf7e6599cd22ee449ddb15466e76fe131e3e6 has been approved by |
bors
added
S-waiting-on-bors
|
Why not |
|
@bors r- Good question, I think Bang would be better |
bors
added
S-waiting-on-author
All other tokens are named by the punctuation they use, rather than by semantics operation they stand for. `!` is the only exception to the rule, let's fix it.
davidtwco
approved these changes
Aug 20, 2020
|
@bors r=davidtwco rollup |
|
📌 Commit 5299297 has been approved by |
bors
added
S-waiting-on-bors
|
PR title need to change too. |
matklad
changed the title
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 20, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs) - rust-lang#75702 (Clean up E0759 explanation) - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads) - rust-lang#75710 (Fix bad printing of const-eval queries) - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 ) - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const) - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move) - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other tokens are named by the punctuation they use, rather than
by semantics operation they stand for.
!is the only exception tothe rule, let's fix it.