Move to intra-doc links for library/core/src/alloc/{layout, global, mod}.rs #75783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
|
r? @kennytm (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Aug 21, 2020
library/core/src/alloc/layout.rs
Outdated
| @@ -145,7 +145,7 @@ impl Layout { | |||
| /// | |||
| /// - If `T` is `Sized`, this function is always safe to call. | |||
| /// - If the unsized tail of `T` is: | |||
| /// - a [slice], then the length of the slice tail must be an intialized | |||
| /// - a [`crate::slice`], then the length of the slice tail must be an intialized | |||
There was a problem hiding this comment.
This links to the module, not the primitive. Slices can't currently be linked to with intra-doc links: #63351, so you need to revert to the original link.
Suggested change
| /// - a [`crate::slice`], then the length of the slice tail must be an intialized | |
| /// - a [`crate::slice`], then the length of the slice tail must be an initialized |
|
r? @jyn514 |
|
@bors r+ rollup |
|
📌 Commit 2500b6d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
jyn514
removed
the
T-rustdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #75080. The files already contained intra-doc links, so there are only minor changes.
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
Known issues:
handle_alloc_error]: Link fromcoretoalloccould not be resolved.slice]: slice is a primitive type, but could not be resolved; had to use [crate::slice] instead.