Use "Fira Sans" for crate list font #76126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Screenshots before/after please. :) |
|
Sorry about that, I meant to :) My docs build still isn't working (it had been going for 2 hours on my desktop so I stopped it), so I had to manually edit the styles in Firefox which means this might not be exactly the output: Before
After
|
|
☔ The latest upstream changes (presumably #76186) made this pull request unmergeable. Please resolve the merge conflicts. |
camelid
force-pushed
the
crate-list-font
branch
from
9ab862e
to
975b510
Compare
|
Rebased. |
camelid
force-pushed
the
crate-list-font
branch
from
975b510
to
13dfd3b
Compare
Fira Sans is what's used for module lists and other item lists. Previously, the default body font, "Source Serif Pro", was used for crate lists, which didn't visually match other item lists.
camelid
force-pushed
the
crate-list-font
branch
from
13dfd3b
to
c86d249
Compare
|
CI is passing now (had to fix some CSS formatting, update a test, etc.). |
GuillaumeGomez
approved these changes
Sep 1, 2020
|
Thanks! @bors: r+ rollup |
|
📌 Commit c86d249 has been approved by |
bors
added
S-waiting-on-bors
|
I just saw in my email bors's message saying that there are merge conflicts, and for a second I thought "Oh no, not more merge conflicts!" before I realized that it was old ;) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 2, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#74880 (Add trailing comma support to matches macro) - rust-lang#76074 (Add new `-Z dump-mir-spanview` option) - rust-lang#76088 (Add more examples to lexicographic cmp on Iterators.) - rust-lang#76099 (Add info about `!` and `impl Trait`) - rust-lang#76126 (Use "Fira Sans" for crate list font) - rust-lang#76132 (Factor out StmtKind::MacCall fields into `MacCallStmt` struct) - rust-lang#76143 (Give a better error message for duplicate built-in macros) - rust-lang#76158 (Stabilise link-self-contained option) - rust-lang#76201 (Move to intra-doc links for library/core/src/panic.rs) - rust-lang#76206 (Make all methods of `std::net::Ipv6Addr` const) - rust-lang#76207 (# Move to intra-doc links for library/core/src/clone.rs) - rust-lang#76212 (Document lint missing_doc_code_examples is nightly-only) - rust-lang#76218 (lexer: Tiny improvement to shebang detection) - rust-lang#76221 (Clean up header in `iter` docs for `for` loops) Failed merges: r? @ghost
ollie27
reviewed
Sep 7, 2020
camelid
added a commit
to camelid/rust
that referenced
this pull request
Sep 7, 2020
I had put it in the wrong file in rust-lang#76126. This should fix it now. Thank you to @ollie27 for pointing this out!
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 9, 2020
…meGomez,ollie27 rustdoc: Fix font CSS for crate lists I had put it in the wrong file in rust-lang#76126. This should fix it now. Thank you to `@ollie27` for pointing this out! --- `@rustbot` modify labels: T-rustdoc C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fira Sans is what's used for module lists and other item lists.
Previously, the default body font, "Source Serif Pro", was used for
crate lists, which didn't visually match other item lists.
@rustbot modify labels: T-rustdoc