Skip to content

Conversation

wesleywiser
Copy link
Member

r? @ghost

@wesleywiser
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Sep 4, 2020

⌛ Trying commit 903c039 with merge 43e6a0ed9376d2a7a0e2f8ddf49bd9dc4abe3264...

@jyn514 jyn514 added the A-mir-opt Area: MIR optimizations label Sep 4, 2020
@bors
Copy link
Collaborator

bors commented Sep 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 43e6a0ed9376d2a7a0e2f8ddf49bd9dc4abe3264 (43e6a0ed9376d2a7a0e2f8ddf49bd9dc4abe3264)

@rust-timer
Copy link
Collaborator

Queued 43e6a0ed9376d2a7a0e2f8ddf49bd9dc4abe3264 with parent af3c6e7, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (43e6a0ed9376d2a7a0e2f8ddf49bd9dc4abe3264): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@wesleywiser
Copy link
Member Author

r? @oli-obk

Since we're at the beginning of new release cycle, I'd like to propose re-enabling this optimization by default. There are no known issues regarding this pass and bootstrap and all tests pass with this enabled.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 8, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 8, 2020

📌 Commit 903c039 has been approved by oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 8, 2020
@bors
Copy link
Collaborator

bors commented Sep 8, 2020

⌛ Testing commit 903c039 with merge 5a6b426...

@bors
Copy link
Collaborator

bors commented Sep 8, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 5a6b426 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 8, 2020
@bors bors merged commit 5a6b426 into rust-lang:master Sep 8, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mir-opt Area: MIR optimizations merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants