Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute rustc sources as part of rustc-dev #76856

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Distribute rustc sources as part of rustc-dev #76856

merged 1 commit into from
Sep 19, 2020

Conversation

jonas-schievink
Copy link
Contributor

They can be used to provide IDE features when working on rustc plugins/backends/etc without having to locate a separate Rust checkout.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 17, 2020
@Mark-Simulacrum
Copy link
Member

One question I guess is whether these are ever useful without the 100+ MB of rlibs that rustc also ships. It might also be the case that if we're going to suggest this then you should be using the "whole source" vendored tarball...

I am inclined to say that those are perhaps interesting to think about but that we should just do this for now though.

@jonas-schievink
Copy link
Contributor Author

One question I guess is whether these are ever useful without the 100+ MB of rlibs that rustc also ships. It might also be the case that if we're going to suggest this then you should be using the "whole source" vendored tarball...

Hmm, yeah. Since having just the compiler sources won't allow actually building a useful compiler (as you'd need the libstd sources too), I'm not sure what such a use case would look like. And having IDE support only seems useful when you can also link against the compiler crates.

@Mark-Simulacrum
Copy link
Member

Well, that's not quite true -- you could build a compiler, because the sources are shipped with a nightly (or whatever channel) std that perfectly matches that compiler tree it should be fine to build the compiler src directly with that std.

But it certainly seems really unlikely that someone would want to do that, when pre-built binaries are available, and I'm not inclined to support that use case (yet at least).

I'm going to go ahead and @bors r+ rollup=never this -- it seems like we'd want to be sure that this is the cause if there are any regressions.

@bors
Copy link
Contributor

bors commented Sep 17, 2020

📌 Commit ee1e934 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020
@bors
Copy link
Contributor

bors commented Sep 19, 2020

⌛ Testing commit ee1e934 with merge ac19c3b...

@bors
Copy link
Contributor

bors commented Sep 19, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing ac19c3b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 19, 2020
@bors bors merged commit ac19c3b into rust-lang:master Sep 19, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 19, 2020
@jonas-schievink jonas-schievink deleted the dist-rustc-src branch February 11, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants