Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap recursive predicate evaluation with ensure_sufficient_stack #76886

Merged
merged 1 commit into from Sep 19, 2020

Conversation

Aaron1011
Copy link
Member

I haven't been able to come up with a minimized test case for #76770,
but this fixes a stack overflow in rustc as well.

I haven't been able to come up with a minimized test case for rust-lang#76770,
but this fixes a stack overflow in rustc as well.
@Aaron1011
Copy link
Member Author

@rust-lang/infra It looks like @rust-highfive didn't run for this PR

@mati865
Copy link
Contributor

mati865 commented Sep 18, 2020

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never (could be perf-sensitive)

@bors
Copy link
Contributor

bors commented Sep 18, 2020

📌 Commit 6a96aea has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 18, 2020
@Dylan-DPC-zz
Copy link

r? @Mark-Simulacrum
(marking for formalities)

@bors
Copy link
Contributor

bors commented Sep 19, 2020

⌛ Testing commit 6a96aea with merge fd702d2...

@bors
Copy link
Contributor

bors commented Sep 19, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing fd702d2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 19, 2020
@bors bors merged commit fd702d2 into rust-lang:master Sep 19, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants