Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use constants to generate less llvm-ir for raw_vec functions #77068

Closed
wants to merge 1 commit into from

Conversation

andjo403
Copy link
Contributor

as a continuation of #72013 to make RawVec::grow smaller I tried to use constants.
I can see that grow_amortized generate 13% less llvm-Ir and in total 3% less llvm-ir is generated for rustc_middle

but maybe the constant calculations is more time then is saved in llvm.

can I get a perf run?

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 22, 2020

⌛ Trying commit 83494b1 with merge c17d5038475891d91c8b55d5603413183eb5f299...

@bors
Copy link
Contributor

bors commented Sep 22, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: c17d5038475891d91c8b55d5603413183eb5f299 (c17d5038475891d91c8b55d5603413183eb5f299)

@rust-timer
Copy link
Collaborator

Queued c17d5038475891d91c8b55d5603413183eb5f299 with parent e0bc267, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c17d5038475891d91c8b55d5603413183eb5f299): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@andjo403
Copy link
Contributor Author

looks like the calculation of the constants was as much works as llvm did compiling it

@andjo403 andjo403 closed this Sep 22, 2020
@andjo403 andjo403 deleted the const_raw_vec branch February 28, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants