Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stdarch submodule #77259

Merged
merged 2 commits into from
Sep 27, 2020
Merged

update stdarch submodule #77259

merged 2 commits into from
Sep 27, 2020

Conversation

dgbo
Copy link
Contributor

@dgbo dgbo commented Sep 27, 2020

This commit update the src/stdarch submodule, we primarily want to include https://github.com/rust-lang/stdarch/pull/918 which provides prefetch hints for aarch64. This PR could deliver ~20% performance gain on our aarch64 server in Filecoin. Wish this could be used as soon as possible.

Thanks.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 27, 2020
@kennytm
Copy link
Member

kennytm commented Sep 27, 2020

This PR updates the stdarch dependency to the current master rust-lang/stdarch@7895ab1 (rust-lang/stdarch#917), but the CI at that commit is currently failing because const_fn_transmute is declared twice in https://github.com/rust-lang/stdarch/blob/master/crates/core_arch/src/lib.rs#L41.

error[E0636]: the feature `const_fn_transmute` has already been declared
  --> crates/core_arch/src/lib.rs:41:5
   |
41 |     const_fn_transmute
   |     ^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

Please either change the commit to rust-lang/stdarch@b422b01 or remove the redundant const_fn_transmute feature.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2020
@dgbo
Copy link
Contributor Author

dgbo commented Sep 27, 2020

This PR updates the stdarch dependency to the current master rust-lang/stdarch@7895ab1 (rust-lang/stdarch#917), but the CI at that commit is currently failing because const_fn_transmute is declared twice in https://github.com/rust-lang/stdarch/blob/master/crates/core_arch/src/lib.rs#L41.

error[E0636]: the feature `const_fn_transmute` has already been declared
  --> crates/core_arch/src/lib.rs:41:5
   |
41 |     const_fn_transmute
   |     ^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

Please either change the commit to rust-lang/stdarch@b422b01 or remove the redundant const_fn_transmute feature.

Thanks for the quick review. The commit is changed to rust-lang/stdarch@b422b01.

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2020
@kennytm
Copy link
Member

kennytm commented Sep 27, 2020

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 27, 2020

📌 Commit 2e64ff9 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2020
@bors
Copy link
Contributor

bors commented Sep 27, 2020

⌛ Testing commit 2e64ff9 with merge 1d216fe...

@bors
Copy link
Contributor

bors commented Sep 27, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: kennytm
Pushing 1d216fe to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants