Skip to content

Add long explanation of E0546 #79533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

Add long explanation of E0546 #79533

merged 2 commits into from
Dec 3, 2020

Conversation

sasurau4
Copy link
Contributor

Helps with #61137

@rust-highfive
Copy link
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2020
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2020

📌 Commit c676439bc7ae5164c4aba5c08a3308d66737e6ca has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2020
@jyn514 jyn514 added A-error-codes Area: Explanation of an error code (--explain) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-stability Area: `#[stable]`, `#[unstable]` etc. F-rustc_attrs Internal rustc attributes gated on the `#[rustc_attrs]` feature gate. labels Nov 29, 2020
sasurau4
sasurau4 commented Nov 29, 2020
View reviewed changes
@petrochenkov
Copy link
Contributor

r? @GuillaumeGomez

@petrochenkov
Copy link
Contributor

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2020
@sasurau4 sasurau4 force-pushed the feature/add-long-explanation-E0546 branch from c676439 to b5503eb Compare November 30, 2020 13:38
@sasurau4
Copy link
Contributor Author

sasurau4 commented Dec 1, 2020

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 1, 2020
GuillaumeGomez
GuillaumeGomez requested changes Dec 1, 2020
View reviewed changes
@sasurau4 sasurau4 force-pushed the feature/add-long-explanation-E0546 branch from b5503eb to fe2dbd7 Compare December 1, 2020 14:17
@sasurau4 sasurau4 force-pushed the feature/add-long-explanation-E0546 branch from fe2dbd7 to ea5aff4 Compare December 1, 2020 15:18
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@jyn514
Copy link
Member

jyn514 commented Dec 2, 2020

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Dec 2, 2020

📌 Commit ea5aff4 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2020
@bors
Copy link
Collaborator

bors commented Dec 3, 2020

⌛ Testing commit ea5aff4 with merge c7cff21...

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing c7cff21 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2020
@bors bors merged commit c7cff21 into rust-lang:master Dec 3, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 3, 2020
@sasurau4 sasurau4 deleted the feature/add-long-explanation-E0546 branch December 3, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-error-codes Area: Explanation of an error code (--explain) A-stability Area: `#[stable]`, `#[unstable]` etc. F-rustc_attrs Internal rustc attributes gated on the `#[rustc_attrs]` feature gate. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sasurau4 @rust-highfive @petrochenkov @bors @GuillaumeGomez @jyn514 @rustbot