Remove giant badge in README #80144
Remove giant badge in README #80144
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@nikomatsakis and @steveklabnik seemed in favor on #73649 which added this badge - I'd be fine with shrinking it down or removing it personally, I agree it seems rather odd right now. |
|
I would also like to remove this. Ideally we could go back to something like how it was before: # The Rust Programming Language |
|
I'm going to wait till after the holidays to approve, in case Steve or Niko want to chime in, but I don't think a header is too helpful. The first paragraph gets right into what this repository is; we don't need a header to signal that too. |
👍
Yes, but practically every open-source project has a header. The page looks kind of “naked” without a title at the top. But we can talk about this after the holidays. |
|
Brought back a top-level heading in d2cc79e |
|
I like it either way. Constantly churning on this isn't great though. |
|
I think we'll wait to get Niko's feedback and then merge this if he's okay with it, since it seems we're either neutral or prefer the simple heading.
Yeah, hopefully we won't change this any more. IMO, the badge looks really weird and out-of-place. |
|
Hey all, I'm catching up on my review queue. I don't have a strong opinion about this, but doing a quick survey of other languages (Go, Ruby, Python) I agree the badge seems unusual (although I do like having the logo). I'm going to r+ but I wanted to cc @Anirban166 (who added the badge) so they're not surprised by the change. @bors r+ |
|
📌 Commit d2cc79e has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
…atsakis Remove giant badge in README Is it meant to be this big? I haven't seen any other open source project with this sort of thing
Rollup of 17 pull requests Successful merges: - rust-lang#78455 (Introduce {Ref, RefMut}::try_map for optional projections in RefCell) - rust-lang#80144 (Remove giant badge in README) - rust-lang#80614 (Explain why borrows can't be held across yield point in async blocks) - rust-lang#80670 (TrustedRandomAaccess specialization composes incorrectly for nested iter::Zips) - rust-lang#80681 (Clarify what the effects of a 'logic error' are) - rust-lang#80764 (Re-stabilize Weak::as_ptr and friends for unsized T) - rust-lang#80901 (Make `x.py --color always` apply to logging too) - rust-lang#80902 (Add a regression test for rust-lang#76281) - rust-lang#80941 (Do not suggest invalid code in pattern with loop) - rust-lang#80968 (Stabilize the poll_map feature) - rust-lang#80971 (Put all feature gate tests under `feature-gates/`) - rust-lang#81021 (Remove doctree::Import) - rust-lang#81040 (doctest: Reset errors before dropping the parse session) - rust-lang#81060 (Add a regression test for rust-lang#50041) - rust-lang#81065 (codegen_cranelift: Fix redundant semicolon warn) - rust-lang#81069 (Add sample code for Rc::new_cyclic) - rust-lang#81081 (Add test for rust-lang#34792) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Is it meant to be this big? I haven't seen any other open source project with this sort of thing