New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfo: Support for destructured locals and function arguments. #8045

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@michaelwoerister
Contributor

michaelwoerister commented Jul 25, 2013

As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests:

let ((u, v), ((w, (x, Struct { a: y, b: z})), Struct { a: ae, b: oe }), ue) =
    ((25, 26), ((27, (28, Struct { a: 29, b: 30})), Struct { a: 31, b: 32 }), 33);  

(Not that you would necessarily want to do a thing like that :P )

Fixes #2533

@jdm

This comment has been minimized.

Contributor

jdm commented Jul 25, 2013

Fantastic work as usual. Your tests are excellent!

@graydon

This comment has been minimized.

Contributor

graydon commented Jul 25, 2013

Agreed, these are great. Thanks!

@michaelwoerister

This comment has been minimized.

Contributor

michaelwoerister commented Jul 25, 2013

@jdm: Thank you. I'll incorporate your comments asap.
@graydon: Thanks :)

@michaelwoerister

This comment has been minimized.

Contributor

michaelwoerister commented Jul 25, 2013

@jdm OK, changes applied.

@michaelwoerister

This comment has been minimized.

Contributor

michaelwoerister commented Jul 25, 2013

@jdm I moved the argument counter into the DebugContext.

@jdm

This comment has been minimized.

jdm commented on d546155 Jul 25, 2013

r+

@brson

This comment has been minimized.

Contributor

brson commented Jul 26, 2013

👍

@bors

This comment has been minimized.

Contributor

bors commented on d546155 Jul 27, 2013

saw approval from jdm
at michaelwoerister@d546155

This comment has been minimized.

Contributor

bors replied Jul 27, 2013

merging michaelwoerister/rust/destructuring = d546155 into auto

This comment has been minimized.

Contributor

bors replied Jul 27, 2013

michaelwoerister/rust/destructuring = d546155 merged ok, testing candidate = e721194

This comment has been minimized.

Contributor

bors replied Jul 27, 2013

fast-forwarding master to auto = e721194

bors added a commit that referenced this pull request Jul 27, 2013

auto merge of #8045 : michaelwoerister/rust/destructuring, r=jdm
As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests: 
```rust
let ((u, v), ((w, (x, Struct { a: y, b: z})), Struct { a: ae, b: oe }), ue) =
    ((25, 26), ((27, (28, Struct { a: 29, b: 30})), Struct { a: 31, b: 32 }), 33);  
```
(Not that you would necessarily want to do a thing like that :P )

Fixes #2533

@bors bors closed this Jul 27, 2013

@michaelwoerister michaelwoerister deleted the michaelwoerister:destructuring branch Jul 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment