debuginfo: Support for destructured locals and function arguments. #8045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic work as usual. Your tests are excellent! |
|
Agreed, these are great. Thanks! |
Conflicts: src/librustc/middle/trans/debuginfo.rs src/test/debug-info/destructured-local.rs
|
@jdm OK, changes applied. |
|
@jdm I moved the argument counter into the DebugContext. |
|
👍 |
bors
added a commit
that referenced
this pull request
Jul 27, 2013
As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests:
```rust
let ((u, v), ((w, (x, Struct { a: y, b: z})), Struct { a: ae, b: oe }), ue) =
((25, 26), ((27, (28, Struct { a: 29, b: 30})), Struct { a: 31, b: 32 }), 33);
```
(Not that you would necessarily want to do a thing like that :P )
Fixes #2533
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2021
Consider NonNull as a pointer type PR 1/2 for issue rust-lang#8045. Add `NonNull` as a pointer class to suppress false positives like `UnsafeCell<NonNull<()>>`. However, this change is not sufficient to handle the cases shared in gtk-rs and Rug in the issue. changelog: none r? `@xFrednet`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2021
…xFrednet Clarify the purpose of the non_send lint PR 2/2 for issue rust-lang#8045. Tried to tone down the warning message and clarify the intention of the lint. Specifically, I added a description that this lint tries to detect "types that are not safe to be sent to another thread". changelog: none r? `@xFrednet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests:
(Not that you would necessarily want to do a thing like that :P )
Fixes #2533