debuginfo: Support for destructured locals and function arguments. #8045

Closed
wants to merge 5 commits into
from

Projects

None yet

5 participants

@michaelwoerister
Contributor

As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests:

let ((u, v), ((w, (x, Struct { a: y, b: z})), Struct { a: ae, b: oe }), ue) =
    ((25, 26), ((27, (28, Struct { a: 29, b: 30})), Struct { a: 31, b: 32 }), 33);  

(Not that you would necessarily want to do a thing like that :P )

Fixes #2533

@jdm
Contributor
jdm commented Jul 25, 2013

Fantastic work as usual. Your tests are excellent!

@graydon
Contributor
graydon commented Jul 25, 2013

Agreed, these are great. Thanks!

@michaelwoerister
Contributor

@jdm: Thank you. I'll incorporate your comments asap.
@graydon: Thanks :)

@michaelwoerister
Contributor

@jdm OK, changes applied.

@michaelwoerister
Contributor

@jdm I moved the argument counter into the DebugContext.

@jdm
jdm commented on d546155 Jul 25, 2013

r+

Contributor
bors replied Jul 27, 2013

saw approval from jdm
at michaelwoerister@d546155

Contributor
bors replied Jul 27, 2013

merging michaelwoerister/rust/destructuring = d546155 into auto

Contributor
bors replied Jul 27, 2013

michaelwoerister/rust/destructuring = d546155 merged ok, testing candidate = e721194

Contributor
bors replied Jul 27, 2013

fast-forwarding master to auto = e721194

@brson
Contributor
brson commented Jul 26, 2013

👍

@bors bors added a commit that referenced this pull request Jul 27, 2013
@bors bors auto merge of #8045 : michaelwoerister/rust/destructuring, r=jdm
As the title says, valid debug info is now generated for any kind of pattern-based bindings like an example from the automated tests: 
```rust
let ((u, v), ((w, (x, Struct { a: y, b: z})), Struct { a: ae, b: oe }), ue) =
    ((25, 26), ((27, (28, Struct { a: 29, b: 30})), Struct { a: 31, b: 32 }), 33);  
```
(Not that you would necessarily want to do a thing like that :P )

Fixes #2533
e721194
@bors bors closed this Jul 27, 2013
@michaelwoerister michaelwoerister deleted the michaelwoerister:destructuring branch Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment