Skip to content

Fix typo in Step trait #80808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2021
Merged

Fix typo in Step trait #80808

merged 1 commit into from
Jan 9, 2021

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Jan 8, 2021

... I don't know how this major typo happened, whoops 🙃

@bors rollup=always
(comment only change)

@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2021
@CAD97
Copy link
Contributor Author

CAD97 commented Jan 8, 2021 •
edited
Loading

In the GH review panel, make sure to expand the view downwards to see that this is on fn backward_checked, which obviously should use the predecessor relation, unlike fn forward_checked which uses the successor operation. For some reason they both said successor.

@nagisa
Copy link
Member

nagisa commented Jan 8, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

📌 Commit 02850d3 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2021
@bors
Copy link
Collaborator

bors commented Jan 9, 2021

⌛ Testing commit 02850d3 with merge ef58949...

@bors
Copy link
Collaborator

bors commented Jan 9, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing ef58949 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2021
@bors bors merged commit ef58949 into rust-lang:master Jan 9, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 9, 2021
@CAD97 CAD97 deleted the patch-3 branch January 9, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CAD97 @rust-highfive @nagisa @bors @m-ou-se @rustbot