Skip to content

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 28, 2021

Use reachable_as_bitset to reuse a bitset from the traversal rather
than allocating it seprately. Additionally check if there are any
unreachable blocks before proceeding.

Use `reachable_as_bitset` to reuse a bitset from the traversal rather
than allocating it seprately. Additionally check if there are any
unreachable blocks before proceeding.
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 28, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 28, 2021

⌛ Trying commit dc6ec35 with merge f4eaeac6891ab5e03034bb6f220380a7bd667d5c...

@bors
Copy link
Collaborator

bors commented Jan 28, 2021

☀️ Try build successful - checks-actions
Build commit: f4eaeac6891ab5e03034bb6f220380a7bd667d5c (f4eaeac6891ab5e03034bb6f220380a7bd667d5c)

@rust-timer
Copy link
Collaborator

Queued f4eaeac6891ab5e03034bb6f220380a7bd667d5c with parent 643a79a, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f4eaeac6891ab5e03034bb6f220380a7bd667d5c): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2021
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 28, 2021

📌 Commit dc6ec35 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2021
@bors
Copy link
Collaborator

bors commented Jan 29, 2021

⌛ Testing commit dc6ec35 with merge b122908...

@bors
Copy link
Collaborator

bors commented Jan 29, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing b122908 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2021
@bors bors merged commit b122908 into rust-lang:master Jan 29, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 29, 2021
@tmiasko tmiasko deleted the remove-allocations branch January 29, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants