Skip to content

Conversation

omasanori
Copy link
Contributor

It seems that relatively new code uses Foo::new() instead of Foo() so I wrote a patch to migrate some structs to the former style.
Is it a right direction? If there are any guidelines not to use new()-style, could you add them to the style guide?

@omasanori
Copy link
Contributor Author

Rebased.

@omasanori
Copy link
Contributor Author

I'll rebase it when PR #8218, which removes std::stackwalk, is merged.

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
@omasanori
Copy link
Contributor Author

Done. r?

bors added a commit that referenced this pull request Aug 5, 2013
It seems that relatively new code uses `Foo::new()` instead of `Foo()` so I wrote a patch to migrate some structs to the former style.
Is it a right direction? If there are any guidelines not to use new()-style, could you add them to the [style guide](https://github.com/omasanori/rust/wiki/Note-style-guide)?
@bors bors closed this Aug 5, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 30, 2021
Limit the ``[`identity_op`]`` lint to integral operands.

changelog: limit ``[`identity_op`]`` to integral operands

In the ``[`identity_op`]`` lint, if the operands are non-integers, then the lint is likely
wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants