Revert LLVM D81803 because it broke Windows 7 #82605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This submodule update reverts <https://reviews.llvm.org/D81803>. While that change is meant to fix a real bug, [LLVM PR42623], it caused new permission errors on Windows 7 that make it unable to build any archives. This is probably the same root cause as [LLVM PR48378]. Fixes rust-lang#81051. We'll file a new Rust issue to track the LLVM resolution. [LLVM PR42623]: https://bugs.llvm.org/show_bug.cgi?id=42623 [LLVM PR48378]: https://bugs.llvm.org/show_bug.cgi?id=48378
cuviper
added
beta-nominated
|
@cuviper: no appropriate reviewer found, use r? to override |
|
rust-highfive
added
the
S-waiting-on-review
|
r? @nikic |
|
@bors r+ |
|
📌 Commit 31814c4 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Merged
apiraino
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2021
[beta] backports This backports some beta-accepted PRs and one additional LLVM fix for s390x. - rustdoc: treat edition 2021 as unstable rust-lang#82207 - Fix popping singleton paths in when generating E0433 rust-lang#82259 - libtest: Fix unwrap panic on duplicate TestDesc rust-lang#82274 - [intra-doc links] Don't check feature gates of items re-exported across crates rust-lang#82295 - rustdoc: Remove duplicate "List of all items" rust-lang#82484 - Substitute erased lifetimes on bad placeholder type rust-lang#82494 - Revert LLVM D81803 because it broke Windows 7 rust-lang#82605 - [SystemZ] Assign the full space for promoted and split outgoing args. rust-lang/llvm-project#95 r? `@Mark-Simulacrum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This submodule update reverts https://reviews.llvm.org/D81803.
While that change is meant to fix a real bug, LLVM PR42623, it caused
new permission errors on Windows 7 that make it unable to build any
archives. This is probably the same root cause as LLVM PR48378.
Fixes #81051. We'll file a new Rust issue to track the LLVM resolution.