Skip to content

Conversation

cjgillot
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 12, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 12, 2021
@bors
Copy link
Collaborator

bors commented Mar 12, 2021

⌛ Trying commit 34e92bb with merge 652124724cf46466b3f672dcf38d1e4f16eae05b...

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

☀️ Try build successful - checks-actions
Build commit: 652124724cf46466b3f672dcf38d1e4f16eae05b (652124724cf46466b3f672dcf38d1e4f16eae05b)

@rust-timer
Copy link
Collaborator

Queued 652124724cf46466b3f672dcf38d1e4f16eae05b with parent b3e19a2, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (652124724cf46466b3f672dcf38d1e4f16eae05b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 13, 2021
@jackh726
Copy link
Member

Nice. Slight regression in ctfe-stress full, but big wins in incr patched. Looks like mostly just #[inline]s.

r? @jackh726
@bors r+

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

📌 Commit 34e92bb has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@bors
Copy link
Collaborator

bors commented Mar 13, 2021

⌛ Testing commit 34e92bb with merge acca818...

@bors
Copy link
Collaborator

bors commented Mar 13, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing acca818 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 13, 2021
@bors bors merged commit acca818 into rust-lang:master Mar 13, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 13, 2021
@cjgillot cjgillot deleted the fhash branch March 14, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants