Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Apr 6, 2021

#83293 showed that this is fairly hot, slightly improves max-rss and cpu cycles, does not noticeably improve instruction counts

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2021
@lcnr
Copy link
Contributor Author

lcnr commented Apr 6, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2021
@bors
Copy link
Collaborator

bors commented Apr 6, 2021

⌛ Trying commit b729815 with merge cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91...

@bors
Copy link
Collaborator

bors commented Apr 6, 2021

☀️ Try build successful - checks-actions
Build commit: cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91 (cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91)

@rust-timer
Copy link
Collaborator

Queued cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91 with parent 5c897d4, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cf8fabe66a5f2f7ef7438c6b0e9810a0045b3c91): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 6, 2021
@jyn514
Copy link
Member

jyn514 commented Apr 6, 2021

No affect on instruction count, but max RSS looks a lot better :)

@estebank
Copy link
Contributor

estebank commented Apr 6, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 6, 2021

📌 Commit b729815 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2021
@bors
Copy link
Collaborator

bors commented Apr 7, 2021

⌛ Testing commit b729815 with merge d8ecefe84897e3b844f3de3a018a7eff7fa605a3...

@bors
Copy link
Collaborator

bors commented Apr 7, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 7, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@lcnr
Copy link
Contributor Author

lcnr commented Apr 7, 2021

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2021
@bors
Copy link
Collaborator

bors commented Apr 7, 2021

⌛ Testing commit b729815 with merge b01026d...

@bors
Copy link
Collaborator

bors commented Apr 7, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing b01026d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2021
@bors bors merged commit b01026d into rust-lang:master Apr 7, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 7, 2021
@lcnr lcnr deleted the probe-perf branch April 9, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants