Skip to content

Add some proc-macro attribute token handling tests #84016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2021
Merged

Add some proc-macro attribute token handling tests #84016

merged 1 commit into from
Apr 10, 2021
+1,199 −66

Conversation

Aaron1011
Copy link
Contributor

Split out from #82608

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 8, 2021
petrochenkov
petrochenkov reviewed Apr 9, 2021
View reviewed changes
@petrochenkov
Copy link
Contributor

r=me with comments addressed.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2021
@Aaron1011
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Apr 9, 2021

📌 Commit dff989b75b3e44f4c3d0dfca8ce82764aedee0d6 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2021
@bors
Copy link
Collaborator

bors commented Apr 9, 2021

⌛ Testing commit dff989b75b3e44f4c3d0dfca8ce82764aedee0d6 with merge 179ae62353233b43de6cdfb24be85563a438e18b...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Apr 10, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 10, 2021
@petrochenkov
Copy link
Contributor

Looks like nonterminal-recollect-attr.rs has platform-dependent output, probably due to some missing #![no_std] boilerplate.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2021
@Aaron1011
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Apr 10, 2021

📌 Commit 6c59111 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 10, 2021
@bors
Copy link
Collaborator

bors commented Apr 10, 2021

⌛ Testing commit 6c59111 with merge a836d9b...

@petrochenkov petrochenkov mentioned this pull request Apr 10, 2021
Merged
@bors
Copy link
Collaborator

bors commented Apr 10, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing a836d9b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 10, 2021
@bors bors merged commit a836d9b into rust-lang:master Apr 10, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 10, 2021
@bors bors mentioned this pull request Apr 10, 2021
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Aaron1011 @petrochenkov @bors @rust-log-analyzer @rust-highfive @rustbot