Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse unnamed fields of struct and union type #84571

Merged
merged 4 commits into from
May 17, 2021
Merged

Parse unnamed fields of struct and union type #84571

merged 4 commits into from
May 17, 2021

Conversation

jedel1043
Copy link
Contributor

Added the unnamed_fields feature gate.

This is a prototype of RFC 2102, so any suggestions are greatly appreciated.

r? @petrochenkov

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 26, 2021
@jedel1043 jedel1043 force-pushed the issue-49804-impl branch 2 times, most recently from 2478847 to 8abfff4 Compare April 26, 2021 14:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed May 3, 2021
View reviewed changes
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/mut_visit.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_pretty/src/pprust/state.rs Show resolved Hide resolved
compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved
compiler/rustc_parse/src/parser/item.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 3, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jedel1043 jedel1043 force-pushed the issue-49804-impl branch 2 times, most recently from 74e34d8 to 70b419c Compare May 3, 2021 23:35
@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jedel1043 jedel1043 marked this pull request as ready for review May 10, 2021 13:31
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 10, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed May 11, 2021
View reviewed changes
compiler/rustc_hir_pretty/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_lowering/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_passes/src/ast_validation.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2021
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 11, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2021
@bors
Copy link
Contributor

bors commented May 17, 2021

⌛ Testing commit 64acb7d with merge 9964284...

@bors
Copy link
Contributor

bors commented May 17, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 9964284 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2021
@bors bors merged commit 9964284 into rust-lang:master May 17, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 17, 2021
@jedel1043 jedel1043 deleted the issue-49804-impl branch May 17, 2021 14:54
@bors bors mentioned this pull request May 17, 2021
Merged
@calebcartwright calebcartwright mentioned this pull request May 24, 2021
Merged
@calebcartwright
Copy link
Member

For future reference please ping me on any and all changes to the rustfmt subtree. The highfive bot is supposed to be configured to do the same but failed to do so here. Now that rustfmt is a subtree and folks are able to modify the rustfmt source here it's really important that the rustfmt team is in the loop on any changes to the rustfmt source to avoid breaking our formatting guarantees for nightly users

@jedel1043
Copy link
Contributor Author

jedel1043 commented May 24, 2021 •
edited
Loading

@calebcartwright Noted. Also, should I open an issue on rust-lang/high-five?

@calebcartwright calebcartwright mentioned this pull request May 24, 2021
Closed
@calebcartwright
Copy link
Member

No worries and thanks @jedel1043. The subtree change is still relatively new and there's unsurprisingly a few kinks to work out.

I've no idea what's up with the lack of bot notifications and am already trying to run that down, so thanks for the offer but no need for you to open an issue.

@Xanewok Xanewok mentioned this pull request May 26, 2021
Merged
@dtolnay dtolnay mentioned this pull request Sep 2, 2021
Closed
@pnkfelix pnkfelix mentioned this pull request Sep 9, 2021
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
b385de7 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 12, 2021
@workingjubilee
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
a5f470b 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 12, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
c09e12b 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
ca0c556 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
8417ac5 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
a8a4504 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
75fae88 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
95306c6 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
fb2d7df 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
@dtolnay dtolnay mentioned this pull request Sep 23, 2021
Merged
calebcartwright pushed a commit to calebcartwright/rust that referenced this pull request Oct 20, 2021
@Manishearth
Rollup merge of rust-lang#88775 - pnkfelix:revert-anon-union-parsing,…
52e1a52 
… r=davidtwco

Revert anon union parsing

Revert PR rust-lang#84571 and rust-lang#85515, which implemented anonymous union parsing in a manner that broke the context-sensitivity for the `union` keyword and thus broke stable Rust code.

Fix rust-lang#88583.
@carbotaniuman carbotaniuman mentioned this pull request Jul 26, 2022
Closed
@petrochenkov petrochenkov mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jedel1043 @rust-highfive @rust-log-analyzer @bors @petrochenkov @calebcartwright @rustbot