use else if in std library #84843
Merged
use else if in std library #84843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@wcampbell0x2a putting [clippy] in the title was confusing to me - this updates the standard library, it doesn't affect clippy at all. I would put that info in the description instead and say something like "use else if in the standard library" for the title. |
Clippy: Decreases indentation and improves readability Signed-off-by: wcampbell <wcampbell1995@gmail.com>
wcampbell0x2a
force-pushed
the
use-else-if-let
branch
from
bc41c66
to
2e559c8
Compare
|
@bors r+ rollup |
|
📌 Commit 2e559c8 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 99. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 4, 2021
…olnay use else if in std library Decreases indentation and improves readability
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 5, 2021
…olnay use else if in std library Decreases indentation and improves readability
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 5, 2021
…olnay use else if in std library Decreases indentation and improves readability
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 5, 2021
…olnay use else if in std library Decreases indentation and improves readability
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#83553 (Update `ptr` docs with regards to `ptr::addr_of!`) - rust-lang#84183 (Update RELEASES.md for 1.52.0) - rust-lang#84709 (Add doc alias for `chdir` to `std::env::set_current_dir`) - rust-lang#84803 (Reduce duplication in `impl_dep_tracking_hash` macros) - rust-lang#84808 (Account for unsatisfied bounds in E0599) - rust-lang#84843 (use else if in std library ) - rust-lang#84865 (rustbuild: Pass a `threads` flag that works to windows-gnu lld) - rust-lang#84878 (Clarify documentation for `[T]::contains`) - rust-lang#84882 (platform-support: Center the contents of the `std` and `host` columns) - rust-lang#84903 (Remove `rustc_middle::mir::interpret::CheckInAllocMsg::NullPointerTest`) - rust-lang#84913 (Do not ICE on invalid const param) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decreases indentation and improves readability