Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0583: Include secondary path in error message #84945

Merged
merged 1 commit into from
May 6, 2021
Merged

E0583: Include secondary path in error message #84945

merged 1 commit into from
May 6, 2021

Conversation

fee1-dead
Copy link
Member

Fixes #84819.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2021
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented May 5, 2021

📌 Commit dcd227d has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 5, 2021
@GuillaumeGomez
Rollup merge of rust-lang#84945 - fee1-dead:E0583-better-message, r=p…
5e827a7 
…etrochenkov

E0583: Include secondary path in error message

Fixes rust-lang#84819.
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 5, 2021
Closed
@GuillaumeGomez
Copy link
Member

Failed in CI: #84962

@bors: r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 5, 2021
@fee1-dead
Copy link
Member Author

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 6, 2021
@GuillaumeGomez
Copy link
Member

@bors: r=petrochenkov rollup

@bors
Copy link
Contributor

bors commented May 6, 2021

📌 Commit 4617b03 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 6, 2021
@Dylan-DPC
Rollup merge of rust-lang#84945 - fee1-dead:E0583-better-message, r=p…
b39024d 
…etrochenkov

E0583: Include secondary path in error message

Fixes rust-lang#84819.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 6, 2021
Closed
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request May 6, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2021
@bors
Auto merge of rust-lang#84982 - Dylan-DPC:rollup-q4cbec2, r=Dylan-DPC
d44f647 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83507 (Implement RFC 2951: Native link modifiers)
 - rust-lang#84328 (Stablize {HashMap,BTreeMap}::into_{keys,values})
 - rust-lang#84712 (Simplify chdir implementation and minimize unsafe block)
 - rust-lang#84851 (:arrow_up: rust-analyzer)
 - rust-lang#84923 (Only compute Obligation `cache_key` once  in `register_obligation_at`)
 - rust-lang#84945 (E0583: Include secondary path in error message)
 - rust-lang#84949 (Fix typo in `MaybeUninit::array_assume_init` safety comment)
 - rust-lang#84950 (Revert PR 83866)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b07834b into rust-lang:master May 6, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 6, 2021
@fee1-dead fee1-dead deleted the E0583-better-message branch June 24, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.

Improve compiler help for missing module error (E0583)
6 participants
@fee1-dead @rust-highfive @petrochenkov @bors @GuillaumeGomez @rustbot