Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous inlining improvements #85892

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Miscellaneous inlining improvements #85892

merged 1 commit into from
Jun 2, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 1, 2021

No description provided.

@rust-highfive
Copy link
Collaborator

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 1, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@bors
Copy link
Contributor

bors commented Jun 1, 2021

⌛ Trying commit 0134410be63be5315de1af7968d74052bf957707 with merge 0af39324cc01dcfdf88025392b55cf411977d739...

@bors
Copy link
Contributor

bors commented Jun 1, 2021

☀️ Try build successful - checks-actions
Build commit: 0af39324cc01dcfdf88025392b55cf411977d739 (0af39324cc01dcfdf88025392b55cf411977d739)

@rust-timer
Copy link
Collaborator

Queued 0af39324cc01dcfdf88025392b55cf411977d739 with parent 7f9ab03, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (0af39324cc01dcfdf88025392b55cf411977d739): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 1, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Jun 1, 2021

Nice!

@bors r+

@bors
Copy link
Contributor

bors commented Jun 1, 2021

📌 Commit 0134410be63be5315de1af7968d74052bf957707 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 1, 2021
@bors
Copy link
Contributor

bors commented Jun 1, 2021

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout i (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self i --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging compiler/rustc_span/src/def_id.rs
CONFLICT (content): Merge conflict in compiler/rustc_span/src/def_id.rs
Auto-merging compiler/rustc_middle/src/ty/mod.rs
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 1, 2021
@bors
Copy link
Contributor

bors commented Jun 1, 2021

☔ The latest upstream changes (presumably #85829) made this pull request unmergeable. Please resolve the merge conflicts.

@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 2, 2021

Rebased to resolve conflicts with #85829 which turned CrateNum into an index type.

@oli-obk
Copy link
Contributor

oli-obk commented Jun 2, 2021

@bors r+

feel free to do r=reviewer yourself for rebases that don't change anything significant

@bors
Copy link
Contributor

bors commented Jun 2, 2021

📌 Commit c1f6495 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 2, 2021
@bors
Copy link
Contributor

bors commented Jun 2, 2021

⌛ Testing commit c1f6495 with merge 1e13a9b...

@bors
Copy link
Contributor

bors commented Jun 2, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1e13a9b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2021
@bors bors merged commit 1e13a9b into rust-lang:master Jun 2, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 2, 2021
@tmiasko tmiasko deleted the i branch June 2, 2021 15:11
@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 3, 2021

feel free to do r=reviewer yourself for rebases that don't change anything significant

I don't have r+ rights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants