Skip to content

Always go through the expn_that_defined query. #86002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2021
Merged

Always go through the expn_that_defined query. #86002

merged 2 commits into from
Jun 5, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jun 4, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 4, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 4, 2021
@bors
Copy link
Collaborator

bors commented Jun 4, 2021

⌛ Trying commit 507a1fd with merge 2d2c97a3e703c439065fb2d1363924a85bd18475...

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2021
@bors
Copy link
Collaborator

bors commented Jun 4, 2021

☀️ Try build successful - checks-actions
Build commit: 2d2c97a3e703c439065fb2d1363924a85bd18475 (2d2c97a3e703c439065fb2d1363924a85bd18475)

@rust-timer
Copy link
Collaborator

Queued 2d2c97a3e703c439065fb2d1363924a85bd18475 with parent efc4e37, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (2d2c97a3e703c439065fb2d1363924a85bd18475): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 5, 2021
@petrochenkov
Copy link
Contributor

Minor regressions in incremental mode since we are tracking more, but this is necessary for correctness.
@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2021

📌 Commit 507a1fd has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2021
@bors
Copy link
Collaborator

bors commented Jun 5, 2021

⌛ Testing commit 507a1fd with merge 2011b89d48fe21fdea1a28a790fc117005c85b98...

@cjgillot cjgillot mentioned this pull request Jun 5, 2021
Merged
bjorn3
bjorn3 reviewed Jun 5, 2021
View reviewed changes
cjgillot
cjgillot commented Jun 5, 2021
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 5, 2021

📌 Commit 3f32738 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Jun 5, 2021

Just spoiled a CI cycle... not my brightest day 😞

@bors
Copy link
Collaborator

bors commented Jun 5, 2021

⌛ Testing commit 3f32738 with merge 6c2dd25...

@bors
Copy link
Collaborator

bors commented Jun 5, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6c2dd25 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2021
@bors bors merged commit 6c2dd25 into rust-lang:master Jun 5, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 5, 2021
@cjgillot cjgillot deleted the expn_that_defined branch June 6, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
8 participants
@cjgillot @rust-highfive @rust-timer @bors @petrochenkov @rust-log-analyzer @bjorn3 @rustbot