Recognize bounds on impls as const bounds #87273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Jul 19, 2021
|
Nice! This is a great fix. |
fee1-dead
force-pushed
the
impl-const-impl-bounds
branch
from
e03406d
to
ad16cd6
Compare
oli-obk
reviewed
Jul 19, 2021
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
impl-const-impl-bounds
branch
from
ad16cd6
to
d2460a1
Compare
This comment has been minimized.
This comment has been minimized.
|
looks like I was wrong, it is reachable, but only in code that already errors. I guess go back to your original PR. Sorry about that. |
fee1-dead
force-pushed
the
impl-const-impl-bounds
branch
from
d2460a1
to
4b82bbe
Compare
|
@bors r+ |
|
📌 Commit 4b82bbe has been approved by |
bors
added
the
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 21, 2021
…=oli-obk Recognize bounds on impls as const bounds r? `@oli-obk`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jul 21, 2021
…=oli-obk Recognize bounds on impls as const bounds r? ``@oli-obk``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 21, 2021
…laumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#87187 (Fix NixOS detection) - rust-lang#87206 (avoid temporary vectors/reuse iterators) - rust-lang#87230 (Fix docblock <table> overflow) - rust-lang#87273 (Recognize bounds on impls as const bounds) - rust-lang#87279 (Add comments explaining the unix command-line argument support.) - rust-lang#87301 (Fix typo in compile.rs) - rust-lang#87311 (Get back the more precise suggestion spans of old regionck) - rust-lang#87321 (Add long explanation for E0722) - rust-lang#87342 (Add long explanation for E0757) Failed merges: - rust-lang#87270 (Don't display <table> in item summary) r? `@ghost` `@rustbot` modify labels: rollup
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk