Add functions to add unsigned and signed integers #87601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
What are two (different from each other) use cases? |
kennytm
added
the
T-libs-api
|
I've wanted both the checked and the wrapping versions of this many times. |
kennytm
reviewed
Jul 30, 2021
|
Possibly-silly question: shouldn't there also be |
|
Yes, I think that it would be less useful but certainly more consistent. Also in this case we would need |
|
☔ The latest upstream changes (presumably #87408) made this pull request unmergeable. Please resolve the merge conflicts. |
3 tasks
a1phyr
force-pushed
the
feature_uint_add_signed
branch
from
23fb4c9
to
b3f4edf
Compare
|
Fixed conflicts, added tracking issue, added signed with unsigned operations and renamed feature. |
JohnCSimon
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #88535) made this pull request unmergeable. Please resolve the merge conflicts. |
a1phyr
force-pushed
the
feature_uint_add_signed
branch
from
b3f4edf
to
2132a9f
Compare
JohnCSimon
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #89414) made this pull request unmergeable. Please resolve the merge conflicts. |
Co-authored-by: kennytm <kennytm@gmail.com>
a1phyr
force-pushed
the
feature_uint_add_signed
branch
from
2132a9f
to
9faf621
Compare
|
Rebased |
kennytm
reviewed
Oct 3, 2021
Co-authored-by: kennytm <kennytm@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
@bors r+ |
|
📌 Commit 47edde1 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Oct 6, 2021
…ennytm
Add functions to add unsigned and signed integers
This PR adds methods to unsigned integers to add signed integers with good overflow semantics under `#![feature(mixed_integer_ops)]`.
The added API is:
```rust
// `uX` is `u8`, `u16`, `u32`, `u64`,`u128`, `usize`
impl uX {
pub const fn checked_add_signed(self, iX) -> Option<Self>;
pub const fn overflowing_add_signed(self, iX) -> (Self, bool);
pub const fn saturating_add_signed(self, iX) -> Self;
pub const fn wrapping_add_signed(self, iX) -> Self;
}
impl iX {
pub const fn checked_add_unsigned(self, uX) -> Option<Self>;
pub const fn overflowing_add_unsigned(self, uX) -> (Self, bool);
pub const fn saturating_add_unsigned(self, uX) -> Self;
pub const fn wrapping_add_unsigned(self, uX) -> Self;
pub const fn checked_sub_unsigned(self, uX) -> Option<Self>;
pub const fn overflowing_sub_unsigned(self, uX) -> (Self, bool);
pub const fn saturating_sub_unsigned(self, uX) -> Self;
pub const fn wrapping_sub_unsigned(self, uX) -> Self;
}
```
Maybe it would be interesting to also have `add_signed` that panics in debug and wraps in release ?
|
⌛ Testing commit 47edde1 with merge 7d03fb603a9cca45cb32a9050881bce9f491746e... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
This looks like a spurious network error :/ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 6, 2021
…arth Rollup of 12 pull requests Successful merges: - rust-lang#87601 (Add functions to add unsigned and signed integers) - rust-lang#88523 (Expand documentation for `FpCategory`.) - rust-lang#89050 (refactor: VecDeques Drain fields to private) - rust-lang#89245 (refactor: make VecDeque's IterMut fields module-private, not just crate-private) - rust-lang#89324 (Rename `std::thread::available_conccurrency` to `std::thread::available_parallelism`) - rust-lang#89329 (print-type-sizes: skip field printing for primitives) - rust-lang#89501 (Note specific regions involved in 'borrowed data escapes' error) - rust-lang#89506 (librustdoc: Use correct heading levels.) - rust-lang#89528 (Fix suggestion to borrow when casting from pointer to reference) - rust-lang#89531 (library std, libc dependency update) - rust-lang#89588 (Add a test for generic_const_exprs) - rust-lang#89591 (fix: alloc-optimisation is only for rust llvm) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods to unsigned integers to add signed integers with good overflow semantics under
#![feature(mixed_integer_ops)].The added API is:
Maybe it would be interesting to also have
add_signedthat panics in debug and wraps in release ?