Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point at unmet explicit lifetime obligation bound #87628

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

estebank
Copy link
Contributor

r? @oli-obk

Split off of #85799.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2021
@estebank
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 30, 2021
@bors
Copy link
Contributor

bors commented Jul 30, 2021

⌛ Trying commit 9b7a28301167cbab9775d6c123d485fbe5ca7d63 with merge 9662333cd6d966baf684fd71269ef0e737587bc3...

@rust-log-analyzer

This comment has been minimized.

@estebank estebank force-pushed the unmet-explicit-lifetime-bound branch from b70ad2c to e5d42af Compare July 31, 2021 15:12
@estebank
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jul 31, 2021

⌛ Trying commit e5d42af with merge 5f55d1bdbcbb69bceac56f9723fa76632d134fee...

@bors
Copy link
Contributor

bors commented Jul 31, 2021

☀️ Try build successful - checks-actions
Build commit: 5f55d1bdbcbb69bceac56f9723fa76632d134fee (5f55d1bdbcbb69bceac56f9723fa76632d134fee)

@rust-timer
Copy link
Collaborator

Queued 5f55d1bdbcbb69bceac56f9723fa76632d134fee with parent 7069a8c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (5f55d1bdbcbb69bceac56f9723fa76632d134fee): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 31, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Aug 2, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Aug 2, 2021

📌 Commit e5d42af has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2021
@bors
Copy link
Contributor

bors commented Aug 2, 2021

⌛ Testing commit e5d42af with merge f63ab6c...

@bors
Copy link
Contributor

bors commented Aug 3, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing f63ab6c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 3, 2021
@bors bors merged commit f63ab6c into rust-lang:master Aug 3, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 3, 2021
@estebank estebank deleted the unmet-explicit-lifetime-bound branch November 9, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants