option: rm implementation of Add #8772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ We should really write a proper monoid library at some point. |
|
Test failure is legitimate. |
Closes #6002 There is consensus that the current implementation should be changed or removed, so removing it seems like the right decision for now.
bors
added a commit
that referenced
this pull request
Aug 27, 2013
Closes #6002 There is consensus that the current implementation should be changed or removed, so removing it seems like the right decision for now.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
[`type_repetition_in_bounds`]: respect MSRV for combining bounds Fixes rust-lang#8772. changelog: [`type_repetition_in_bounds`]: respect msrv for combining `?Sized` bound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6002
There is consensus that the current implementation should be changed or
removed, so removing it seems like the right decision for now.