Test and fix size_hint for slice’s [r]split* iterators
#87974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffahn
force-pushed
the
slice_split_size_hints
branch
from
389953b to
8d1d63e
Compare
Adds extensive test for all the [r]split* iterators. Fixes size_hint upper bound for split_inclusive* iterators which was one higher than necessary for non-empty slices. Fixes size_hint lower bound for [r]splitn* iterators when n==0, which was one too high.
steffahn
force-pushed
the
slice_split_size_hints
branch
from
8d1d63e to
31e49f0
Compare
|
@rustbot label T-libs, A-iterators, A-slice |
rustbot
added
the
T-libs
|
@rust-highfive failed. I’m choosing at random from this list. r? @dtolnay |
steffahn
force-pushed
the
slice_split_size_hints
branch
2 times, most recently
from
a467715 to
8cb1cec
Compare
This comment has been minimized.
This comment has been minimized.
|
Ah, the damn tidy check -.- By the way (note for review:) I was only force-pushing to amend the new commit. |
steffahn
force-pushed
the
slice_split_size_hints
branch
from
8cb1cec to
0bb11f4
Compare
This comment has been minimized.
This comment has been minimized.
steffahn
force-pushed
the
slice_split_size_hints
branch
from
67ac748 to
3f0d04e
Compare
|
@bors r+ |
|
📌 Commit 3f0d04e has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds extensive test (of
size_hint) for all the [r]split* iterators.Fixes
size_hintupper bound for split_inclusive* iterators which was one higher than necessary for non-empty slices.Fixes
size_hintlower bound for [r]splitn* iterators when n == 0, which was one too high.Lower bound being one too high was a logic error, violating the correctness condition of
size_hint.Edit: I’ve opened an issue for that bug, so this PR fixes #87978