Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automatic migration for assert!(.., string). #87982

Merged
merged 3 commits into from
Aug 15, 2021
Merged

Add automatic migration for assert!(.., string). #87982

merged 3 commits into from
Aug 15, 2021

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Aug 12, 2021

Fixes part of #87313.

@m-ou-se m-ou-se added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`. D-edition Diagnostics: An error or lint that should account for edition differences. labels Aug 12, 2021
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2021
@m-ou-se m-ou-se mentioned this pull request Aug 12, 2021
Closed
@bors
Copy link
Contributor

bors commented Aug 13, 2021

☔ The latest upstream changes (presumably #87980) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 14, 2021

📌 Commit 8fedb31 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2021
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87982 - m-ou-se:non-fmt-panic-assert-str, r…
839be21 
…=cjgillot

Add automatic migration for assert!(.., string).

Fixes part of rust-lang#87313.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 15, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87982 - m-ou-se:non-fmt-panic-assert-str, r…
1b7c64b 
…=cjgillot

Add automatic migration for assert!(.., string).

Fixes part of rust-lang#87313.
This was referenced Aug 15, 2021
Closed
Closed
@bors
Copy link
Contributor

bors commented Aug 15, 2021

⌛ Testing commit 8fedb31 with merge 2d2bc94...

@bors
Copy link
Contributor

bors commented Aug 15, 2021

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 2d2bc94 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 15, 2021
@bors bors merged commit 2d2bc94 into rust-lang:master Aug 15, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 15, 2021
@m-ou-se m-ou-se deleted the non-fmt-panic-assert-str branch August 16, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`. D-edition Diagnostics: An error or lint that should account for edition differences. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@m-ou-se @rust-highfive @bors @cjgillot @rustbot