Skip to content

Simplify lifetimes_from_impl_trait_bounds #88626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2021
Merged

Simplify lifetimes_from_impl_trait_bounds #88626

merged 2 commits into from
Sep 5, 2021

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Sep 3, 2021

Part of #87234

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2021
@cjgillot
Copy link
Contributor Author

cjgillot commented Sep 3, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 3, 2021
@bors
Copy link
Collaborator

bors commented Sep 3, 2021

⌛ Trying commit fed4410 with merge 0c80ec8b7cd00421635e1d228f51c61e4f5419bc...

@bors
Copy link
Collaborator

bors commented Sep 3, 2021

☀️ Try build successful - checks-actions
Build commit: 0c80ec8b7cd00421635e1d228f51c61e4f5419bc (0c80ec8b7cd00421635e1d228f51c61e4f5419bc)

@rust-timer
Copy link
Collaborator

Queued 0c80ec8b7cd00421635e1d228f51c61e4f5419bc with parent 4878034, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (0c80ec8b7cd00421635e1d228f51c61e4f5419bc): comparison url.

Summary: ERROR categorizing benchmark run!

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 4, 2021
@petrochenkov petrochenkov added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2021
@Mark-Simulacrum
Copy link
Member

Perf is now ready, looks neutral.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 4, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 4, 2021

📌 Commit fed4410 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2021
@bors
Copy link
Collaborator

bors commented Sep 4, 2021

⌛ Testing commit fed4410 with merge 3baa466...

@bors
Copy link
Collaborator

bors commented Sep 5, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 3baa466 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 5, 2021
@bors bors merged commit 3baa466 into rust-lang:master Sep 5, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 5, 2021
@bors bors mentioned this pull request Sep 5, 2021
Merged
@cjgillot cjgillot deleted the lfitb branch September 6, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cjgillot @rust-timer @bors @Mark-Simulacrum @petrochenkov @rust-highfive @rustbot