Document when to use Windows' symlink_dir vs. symlink_file
#88647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously unclear which should be used when.
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I wasn't sure about the phrase "non-directory file" but it's the best I could think of considering how overloaded the word "file" is. |
|
@bors r+ rollup |
|
📌 Commit 2d95b5b has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 6, 2021
Rollup of 6 pull requests Successful merges: - rust-lang#88602 (Add tests for some const generics issues) - rust-lang#88647 (Document when to use Windows' `symlink_dir` vs. `symlink_file`) - rust-lang#88659 (Remove SmallVector mention) - rust-lang#88661 (Correct typo) - rust-lang#88673 (Fix typo: needede -> needed) - rust-lang#88685 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously unclear why there are two functions and when they should be used.
Fixes: #88635