bootstrap: Update comment in config.library.toml. #89392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downloading LLVM from CI works for all platforms now.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 1cf905f has been approved by |
bors
added
S-waiting-on-bors
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Sep 30, 2021
bootstrap: Update comment in config.library.toml. Downloading LLVM from CI works for all platforms now. All other templates in this directory already have the proper comment. Seems this one was neglected.
jyn514
reviewed
Sep 30, 2021
| @@ -10,6 +10,6 @@ bench-stage = 0 | |||
| incremental = true | |||
|
|
|||
| [llvm] | |||
| # Will download LLVM from CI if available on your platform (Linux only for now) | |||
| # Will download LLVM from CI if available on your platform. | |||
| # https://github.com/rust-lang/rust/issues/77084 tracks support for more platforms | |||
There was a problem hiding this comment.
Hmm, I'm not sure it makes sense to keep this comment now the issue is closed.
There was a problem hiding this comment.
you're right, i forgot to delete that one. one sec
|
ooh, looks like i was just too late and bors beat me to it. do i need to make a new PR for the second commit? |
|
and yup it failed @bors r+ rollup |
|
📌 Commit 098d862 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 30, 2021
bootstrap: Update comment in config.library.toml. Downloading LLVM from CI works for all platforms now. All other templates in this directory already have the proper comment. Seems this one was neglected.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 30, 2021
bootstrap: Update comment in config.library.toml. Downloading LLVM from CI works for all platforms now. All other templates in this directory already have the proper comment. Seems this one was neglected.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2021
…arth Rollup of 8 pull requests Successful merges: - rust-lang#88782 (Fix ICE when `start` lang item has wrong generics) - rust-lang#89202 (Resolve infered types when complaining about unexpected call type ) - rust-lang#89248 (Suggest similarly named associated items in trait impls) - rust-lang#89303 (Add `#[must_not_suspend]` to some types in std) - rust-lang#89306 (thread: implements available_concurrency on haiku) - rust-lang#89314 (fix(lint): don't suggest refutable patterns to "fix" irrefutable bind) - rust-lang#89370 (CTFE: tweak aggregate rvalue handling) - rust-lang#89392 (bootstrap: Update comment in config.library.toml.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading LLVM from CI works for all platforms now.
All other templates in this directory already have the proper comment. Seems this one was neglected.